Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0: Add RCpair copy! for complex. Rename region->dims. Remove deprecation. #17

Merged
merged 9 commits into from
Apr 29, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Mar 11, 2024

Part of JuliaImages/ImageFiltering.jl#271

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4245504) to head (e04592d).

❗ Current head e04592d differs from pull request most recent head 8890794. Consider uploading reports for the commit 8890794 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #17      +/-   ##
===========================================
+ Coverage   94.44%   100.00%   +5.55%     
===========================================
  Files           1         1              
  Lines          36        43       +7     
===========================================
+ Hits           34        43       +9     
+ Misses          2         0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanButterworth IanButterworth changed the title add RCpair copy! for complex Add RCpair copy! for complex. Rename region->dims. Remove deprecation. Mar 15, 2024
@IanButterworth
Copy link
Member Author

@timholy my plan, given this is green, is to:

Let me know if you agree. Thanks

@IanButterworth
Copy link
Member Author

Or maybe it doesn't need to move org?

@IanButterworth
Copy link
Member Author

Bump

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks, then merge at will.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
@timholy
Copy link
Member

timholy commented Apr 10, 2024

I agree with the plan. My move of IncrementalSVD revealed that we'll have to change the UUID, as General has a guard against registering a package with the same uuid as in HolyLabRegistry.

I will also enhance the README before we release in General, as it seems every so slightly threadbare now 😆

Project.toml Outdated Show resolved Hide resolved
@IanButterworth IanButterworth changed the title Add RCpair copy! for complex. Rename region->dims. Remove deprecation. v1.0.0: Add RCpair copy! for complex. Rename region->dims. Remove deprecation. Apr 29, 2024
@IanButterworth
Copy link
Member Author

github actions runners seem to be having codecov upload issues but tests pass

@IanButterworth IanButterworth merged commit d97bd79 into master Apr 29, 2024
5 of 6 checks passed
@IanButterworth IanButterworth deleted the ib/add_copy branch April 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants