Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix brew style path checking #17482

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Fix brew style path checking #17482

merged 5 commits into from
Jun 13, 2024

Commits on Jun 13, 2024

  1. style: fix tap checking 

    `brew style` tap support was broken in 7d0ac4d (Homebrew#17357), so now
something like `brew style homebrew/core` exits without checking
anything. This happens because the new file-handling logic doesn't
do anything with a tap path. Previously, a tap path would be added
to `ruby_files` but now it isn't added to any of the arrays of files
to check.

This fixes the issue by adding some logic to add the path to the
`ruby_files` array if it's a tap.
    @samford @MikeMcQuaid
    samford authored and MikeMcQuaid committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    af02d94 View commit details
    Browse the repository at this point in the history

  2. style: fix path checking. 

    Add all necessary files to the path, using globs when necessary.
    @MikeMcQuaid
    MikeMcQuaid committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    9e863aa View commit details
    Browse the repository at this point in the history

  3. style: ignore actionlint false-positive.

    @MikeMcQuaid
    MikeMcQuaid committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    349627e View commit details
    Browse the repository at this point in the history

  4. docs: brew style --fix

    @MikeMcQuaid
    MikeMcQuaid committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    1b8bddd View commit details
    Browse the repository at this point in the history

  5. workflows/docs: temporarily disable brew style docs check.

    @MikeMcQuaid
    MikeMcQuaid committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ca2ac3d View commit details
    Browse the repository at this point in the history