Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/typecheck: Support typechecking in taps #18027

Merged
merged 3 commits into from
Aug 19, 2024

Commits on Aug 12, 2024

  1. dev-cmd/typecheck: Support typechecking in taps

    ```shell
    $ brew typecheck homebrew/bundle
    No sorbet/ directory found. Maybe you want to run 'srb init'?
    
    A type checker for Ruby
    
    Usage:
      srb                                 Same as "srb t"
      srb (init | initialize)             Initializes the `sorbet` directory
      srb rbi [options]                   Manage the `sorbet` directory
      srb (t | tc | typecheck) [options]  Typechecks the code
    
    Options:
      -h, --help     View help for this subcommand.
      --version      Show version.
    
    For full help:
      https://sorbet.org
    Check https://docs.brew.sh/Typechecking for more information on how to resolve these errors.
    ```
    issyl0 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    807093f View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. dev-cmd/typecheck: Use Sorbet's --dir to set the tap path

    - This means we don't have to copy config files around,
      and users get instant results rather than having
      to run `srb init`.
    issyl0 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    feedc5c View commit details
    Browse the repository at this point in the history
  2. dev-cmd/typecheck: Disallow --fix when in taps too

    - This could autocorrect files in Homebrew/brew when
      we should be targetting the tap, because of the
      weird hierarchy thing
      (#18027 (comment)).
    
    Co-authored-by: Bo Anderson <mail@boanderson.me>
    issyl0 and Bo98 committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    4e37436 View commit details
    Browse the repository at this point in the history