-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compilers: drop support for GCC 4.9, 5 and 6 #18127
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.9 (removed) and 5 & 6 (planned to remove in October). May need to check on which LTS distros this will impact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rough estimates for some common older Linux:
I didn't see any usage of GCC 4.9 or 6 from quick glance.
GCC 5 could impact Ubuntu 16 users and was our original default prior to newer Ubuntu/toolchain.
EDIT: Do we have analytics for GCC actually used? We strip out the
--cc
value in https://formulae.brew.sh/analytics/brew-command-run-options/365d/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not. Stripping out arg values is intended behaviour because they are not validated so could contain any input. Though
--cc
isn't the only way it can be used as formulae can do e.g.ENV.public_send(:"gcc-5")
(horrible API we should really fix but whatever it's public API nonetheless).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably infer some of this from https://formulae.brew.sh/analytics/os-version/365d/
I think it'd be reasonable to require a GCC 7 minimum version for Homebrew based on the above. We already enforce relatively newer
curl
andgit
.