-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/info: show size information #18172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me so far, nice work!
Would be interested (post-merge) in benchmarks for this so we can consider how to get to being able to put these in the API.
CC @reitermarkus also for thoughts on whether the parallel downloading work overlaps here and when it might be ready.
Yes, slight overlap, but the changes to |
2feba60
to
ad216b6
Compare
e30935d
to
c53a7e3
Compare
Updated and should be ready for review. Will be working on more JSON API code path in #18403 (WIP). Changes include:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @cho-m!
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com> Co-authored-by: Markus Reiter <me@reitermark.us>
d9a20c2
to
ea0776c
Compare
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Follow up to #18144
Proof of concept for now on getting size info into
brew info
.May need to see if any better ways to get this information out of the manifest. A bit trickier than just tab info.
For comparison
Download-Size
andInstalled-Size
.Package Size
andInstalled Size
.Also, mainly an approximate if pouring bottle into non-standard prefix.