Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Dec 6, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

inherited_options feature was originally added to support cascading option :univeral back in 793d6de.

This is now dead code given :universal support was removed.

inherited_options feature was originally added to support cascading
`option :univeral` back in 793d6de.

This is now dead code given `:universal` support was removed.
Copilot AI review requested due to automatic review settings December 6, 2025 19:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the inherited_options feature from Homebrew's dependency resolution system. The feature was originally added to support cascading the :universal option from parent formulas to their dependencies, but became dead code after :universal support was removed.

Key changes:

  • Removed inherited_options parameter from Dependency#satisfied? and Dependency#missing_options methods
  • Simplified FormulaInstaller to work with arrays of Dependency objects instead of [Dependency, Options] tuples
  • Removed the inherited_options_for method and Formula#require_universal_deps? method

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Library/Homebrew/dependency.rb Removed inherited_options parameter from satisfied? and missing_options methods
Library/Homebrew/test/dependency_spec.rb Updated test to call satisfied? without the now-removed first parameter
Library/Homebrew/formula.rb Removed unused require_universal_deps? method
Library/Homebrew/formula_installer.rb Simplified dependency handling to work with Dependency arrays instead of [Dependency, Options] tuples; removed inherited_options_for method and related logic
Library/Homebrew/install.rb Updated type signatures and code to work with simplified Dependency arrays
Library/Homebrew/cmd/info.rb Updated satisfied? call to remove the empty array parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of deleted code, very nice, thanks again @cho-m!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 7, 2025
Merged via the queue into main with commit 2a08ac2 Dec 7, 2025
43 checks passed
@MikeMcQuaid MikeMcQuaid deleted the remove-inherited_options branch December 7, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants