Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 20, 2026

  • Create test fixtures for casks with OS-specific artifacts
    • Cask with no on_system blocks (reusing existing local-caffeine)
    • Cask with on_system blocks but no OS-specific artifacts (with-os-blocks-no-os-artifacts)
    • Cask with on_macos/on_linux blocks with macOS-only artifacts (with-os-specific-artifacts)
  • Add test cases in cask_spec.rb
  • Run tests to verify
  • Fix failing tests in generate-cask-ci-matrix
  • Fix Sorbet type errors

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…type errors

Co-authored-by: SMillerDev <1484494+SMillerDev@users.noreply.github.com>
@SMillerDev
Copy link
Member

@copilot the tests are failing, please fix them

The issue was that filtered_runners was initialized to all RUNNERS,
then filtered by macOS architectures which removed Linux runners.
Changed to only start with MACOS_RUNNERS, then add Linux runners
separately if the cask supports Linux.

Co-authored-by: SMillerDev <1484494+SMillerDev@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 20, 2026

@copilot the tests are failing, please fix them

Fixed in 3b9abc0. The issue was that filter_runners was filtering all runners (including Linux) based on macOS architectures. Changed it to only filter macOS runners initially, then add Linux runners separately if the cask supports Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants