Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase number of long build slots #170

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

carlocab
Copy link
Member

Now that Sequoia bottling is largely complete for arm64, let's increase
the number of long build slots again.

Instead of increasing the number of dispatch build slots to the same
number, let's decrease it instead. This guarantees that 1/4 of our
orchestrator-managed runners are always available to PRs.

Now that Sequoia bottling is largely complete for arm64, let's increase
the number of long build slots again.

Instead of increasing the number of dispatch build slots to the same
number, let's decrease it instead. This guarantees that 1/4 of our
orchestrator-managed runners are always available to PRs.
@Bo98
Copy link
Member

Bo98 commented Sep 15, 2024

Thoughts on instead of a dispatch limit we continuously tweak that we instead just lower the priority of dispatch jobs to be behind PR jobs?

@carlocab
Copy link
Member Author

carlocab commented Sep 16, 2024

Thoughts on instead of a dispatch limit we continuously tweak that we instead just lower the priority of dispatch jobs to be behind PR jobs?

We could do that, but we'd probably tweak that for mass bottling anyway because I don't think it should be lower priority than PR jobs then -- something similar to this (higher priority, but limited slots) sounds better for mass bottling.

@carlocab
Copy link
Member Author

Merging now since long builds are stuck queueing with no other jobs running. Happy to change this to something better later.

@carlocab carlocab merged commit 05472be into main Sep 16, 2024
4 checks passed
@carlocab carlocab deleted the increase-long-build-slots branch September 16, 2024 10:32
@Bo98
Copy link
Member

Bo98 commented Sep 16, 2024

We could do that, but we'd probably tweak that for mass bottling anyway because I don't think it should be lower priority than PR jobs then

We tell everyone not to not swamp the queue so PRs can get through so raising the priority of PRs would mean we don't need to manually watch the queue as much.

@carlocab
Copy link
Member Author

We tell everyone not to not swamp the queue so PRs can get through so raising the priority of PRs would mean we don't need to manually watch the queue as much.

Not sure why we're doing that, tbh. We shouldn't need to watch the queue given the fixed number of slots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants