Add Homespun Instant Access v2.9.3 #42319
Conversation
Homespun is a music instruction site. Homespun Instant Access is the application to play Homespun lessions.
Casks/homespun-instant-access.rb
Outdated
| } | ||
|
|
||
| uninstall quit: 'com..mm_launcher', | ||
| delete: '/Applications/Homespun Instant Access.app' |
There was a problem hiding this comment.
Are you sure adding this app is the only thing the installer does? That is highly unlikely.
There was a problem hiding this comment.
I agree with you, that probably it does something very strange (since it requires password during the installation.
How can I find out what the application is installing?
I am using app cleaner to remove applications: This reports the following:
What out of this data should be removed? Something more?
Casks/homespun-instant-access.rb
Outdated
| sudo: true, | ||
| } | ||
|
|
||
| uninstall quit: 'com..mm_launcher', |
There was a problem hiding this comment.
Unfortunately this seems to be the id of this bundle. See the following output while the application is running:
/u/l/H/L/T/c/homebrew-cask ❯❯❯ developer/bin/list_running_app_ids bundle_id app_name
--------------------------------------
.... more stuff
com..mm_launcher Homespun Instant Access
.... more stuff
There was a problem hiding this comment.
It’s fine if it is, I was just checking if it wasn’t a copying mistake.
Casks/homespun-instant-access.rb
Outdated
| homepage 'https://www.homespun.com/direct-download/' | ||
|
|
||
| installer script: { | ||
| executable: "#{staged_path}/Homespun Instant Access Installer.app/Contents/MacOS/Homespun Instant Access Installer", |
There was a problem hiding this comment.
This isn’t a script, it’s simply the binary inside the app bundle.
This need to be installer manual: on the .app instead.
There was a problem hiding this comment.
I have tried manual as well. But I was not sure, how such situation is usually handled. I thought it was beneficial to the user would not have to locate the installer manually and click on it, instead, I thought it would be easier that the installer ist automatically started.
But I am new to this project and I have not seen many different casks how the work.
If I get you correctly, a manual installation is the best for such situation, therefore I will change it.
There was a problem hiding this comment.
I thought it was beneficial to the user would not have to locate the installer manually and click on it, instead, I thought it would be easier that the installer ist automatically started.
But that also means the installation blocks scripts (much like it did Travis), which is bad. This is standard procedure for us, and users already expect it.
We do have plans for it to be different in the future — see #24377.
There was a problem hiding this comment.
Perfect, I will update this PR. I fully understand that Travis has to succeed.
| installer manual: 'Homespun Instant Access Installer.app' | ||
|
|
||
| uninstall quit: 'com..mm_launcher', | ||
| delete: '/Applications/Homespun Instant Access.app' |
There was a problem hiding this comment.
How can I find out what the application is installing?
Ideally, the developer will have that information somewhere, like instructions on how to completely uninstall the app.
But you can also take a look at our other developer/bin scripts, namely list_installed_launchjob_ids, list_loaded_kext_ids. They might turn up something more.
There was a problem hiding this comment.
I have checked both list_loaded_kext_ids and list_installed_launchjob_ids . Both did not report anything related to this application.
Unfortunately I am not the developer of the Homespun application. (Just a user)
There was a problem hiding this comment.
I am not the developer of the Homespun application.
I know, but the information may be posted somewhere on the website or there may be a forum where you can ask.
There was a problem hiding this comment.
Agreed, I was searching a bit on the webpage. But definitely a good Idea is the forum (although it's a bit music related, but maybe somebody is willing to help)
There was a problem hiding this comment.
Currently checking with the support....
Homespun is a music instruction site.
Homespun Instant Access is the application to play Homespun lessons.
I am not sure if I implemented this cask correctly. The Application requires an installer script to be run. I was able to start this script, but It still requires manual input (clicks) from the user. (First a confirmation and then a screen to accept the license agreement)
After making all changes to the cask:
brew cask audit --download {{cask_file}}is error-free.brew cask style --fix {{cask_file}}reports no offenses.Additionally, if adding a new cask:
brew cask install {{cask_file}}worked successfully.brew cask uninstall {{cask_file}}worked successfully.