Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clojure-lsp: migrate to clojure-lsp tap #150644

Closed
wants to merge 1 commit into from

Conversation

TheRealKeto
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The maintainers of clojure-lsp have migrated over to their own tap, so we should make sure users know this through a migration.

Based on their own installation guide users are recommended to use their tap over Homebrew/core. Furthermore, their claims on their own tap indicates that this package is outdated in Homebrew/core; the latest version of clojure-lsp has failed to build due to a change in build systems according to #139929, which should justify migrating over their tap.

The maintainers of clojure-lsp have migrated over to their
own tap, so we should make sure users know this through a
migration.
@TheRealKeto TheRealKeto requested review from MikeMcQuaid and a team as code owners October 12, 2023 04:59
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 12, 2023
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we don't recommend external taps and we certainly don't remove formulae because they exist somewhere else.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @SMillerDev.

@TheRealKeto TheRealKeto deleted the migrate/clojure-lsp branch October 12, 2023 14:59
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants