Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Semgrep opam's solver timeout #191912

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Bump Semgrep opam's solver timeout #191912

merged 1 commit into from
Sep 26, 2024

Conversation

ajbt200128
Copy link
Contributor

Fixes issue in #191306 and #191178, where Opam was timing out

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. ocaml OCaml use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Sep 25, 2024
@ajbt200128 ajbt200128 force-pushed the austin/saf-1589-opam-timing-out-in-1880-homebrew-pr branch from e51e956 to 7b08d32 Compare September 25, 2024 21:50
@ajbt200128
semgrep: bump opam's solver timeout
fdf3b3f 
Homebrew#191178 and Homebrew#191306 were
failing due to opam's solver timing out. We (Semgrep) fixed this
in our own CI by bumping the solver's timeout
@ajbt200128 ajbt200128 force-pushed the austin/saf-1589-opam-timing-out-in-1880-homebrew-pr branch from 7b08d32 to fdf3b3f Compare September 25, 2024 21:55
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 25, 2024
carlocab
carlocab approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Sep 26, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 26, 2024
Merged via the queue into Homebrew:master with commit 7acb263 Sep 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles ocaml OCaml use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajbt200128 @carlocab @BrewTestBot