Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate echo-es in post-install instructions #882

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

ZhongRuoyu
Copy link
Member

Follow-up to #881 (review).

install.sh Outdated Show resolved Hide resolved
@ZhongRuoyu ZhongRuoyu closed this Sep 26, 2024
@ZhongRuoyu ZhongRuoyu deleted the printf-fish-only branch September 26, 2024 11:06
This is more readable and portable.
@ZhongRuoyu ZhongRuoyu restored the printf-fish-only branch September 26, 2024 17:35
@ZhongRuoyu ZhongRuoyu reopened this Sep 26, 2024
@ZhongRuoyu ZhongRuoyu changed the title Preserve original post-install instructions for non-Fish shells Use separate echo-es in post-install instructions Sep 26, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better still, thanks @ZhongRuoyu!

@ZhongRuoyu ZhongRuoyu merged commit b1c25a7 into master Sep 27, 2024
3 checks passed
@ZhongRuoyu ZhongRuoyu deleted the printf-fish-only branch September 27, 2024 02:39
@ZhongRuoyu
Copy link
Member Author

Thanks for the inputs everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants