[FEAT] @IterableMapping을 활용한 매핑 로직 변경

HongDam-org · Nov 28, 2023 · a2aa4d0 · a2aa4d0
1 parent ca4bdc5
commit a2aa4d0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/backend/src/main/java/com/twtw/backend/domain/group/mapper/GroupMapper.java b/backend/src/main/java/com/twtw/backend/domain/group/mapper/GroupMapper.java
@@ -7,10 +7,9 @@
 import com.twtw.backend.domain.group.entity.GroupMember;
 import com.twtw.backend.domain.member.entity.Member;
 
-import org.mapstruct.Mapper;
-import org.mapstruct.Mapping;
-import org.mapstruct.MappingConstants;
+import org.mapstruct.*;
 
+import java.util.List;
 import java.util.UUID;
 
 @Mapper(componentModel = MappingConstants.ComponentModel.SPRING)
@@ -33,4 +32,13 @@ public interface GroupMapper {
     @Mapping(target = "memberId", source = "member.id")
     ShareInfoResponse toShareInfo(GroupMember groupMember);
 
+    @Named("groupMemberToGroupInfoResponse")
+    @Mapping(target = "groupId", source = "groupMember.group.id")
+    @Mapping(target = "leaderId", source = "groupMember.group.leaderId")
+    @Mapping(target = "name", source = "groupMember.group.name")
+    @Mapping(target = "groupImage", source = "groupMember.group.groupImage")
+    GroupInfoResponse toGroupInfoResponse(GroupMember groupMember);
+
+    @IterableMapping(qualifiedByName = "groupMemberToGroupInfoResponse")
+    List<GroupInfoResponse> toMyGroupsInfo(List<GroupMember> groupMembers);
 }
diff --git a/backend/src/main/java/com/twtw/backend/domain/group/service/GroupService.java b/backend/src/main/java/com/twtw/backend/domain/group/service/GroupService.java
@@ -114,16 +114,8 @@ public GroupInfoResponse getGroupInfoResponse(Group group) {
         return groupMapper.toGroupInfo(group);
     }
 
-    @Transactional
+    @Transactional(readOnly = true)
     public List<GroupInfoResponse> getMyGroups(){
-        List<GroupInfoResponse> responses = new ArrayList<>();
-
-        Member loginMember = authService.getMemberByJwt();
-
-        for(GroupMember groupMember : loginMember.getGroupMembers()){
-            responses.add(groupMapper.toGroupInfo(groupMember.getGroup()));
-        }
-
-        return responses;
+        return groupMapper.toMyGroupsInfo(authService.getMemberByJwt().getGroupMembers());
     }
 }