[FEAT] Feat/auth test #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohksj77
reviewed
Nov 23, 2023
| // when | ||
| AfterLoginResponse response = authService.saveMember(kakaoRequest); | ||
| // then | ||
| assertThat(response.getStatus().equals(AuthStatus.SIGNIN)); |
There was a problem hiding this comment.
assertThat() 안의 값이 true인지 false인지는 테스트 통과에 영향을 안줘..
|
|
||
| @DatabaseTest | ||
| @DisplayName("AuthService의 ") | ||
| public class AuthServiceTest { |
There was a problem hiding this comment.
서비스 테스트는 LoginTest를 상속 받으면 돼! 그리고 DatabaseTest 어노테이션은 LoginTest에 있기 때문에 필요 없음!
jinjoo-lab
force-pushed
the
feat/auth-test
branch
from
de06c2a to
9c01755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가/수정한 기능 설명
특이사항
check list