Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] usc rewrite compatibility #20

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Drewol
Copy link

@Drewol Drewol commented Sep 28, 2024

Just the initial stuff to clear up most script errors in the rewrite I'm working on at https://github.com/Drewol/kson-rs

A lot of gameplay things are still wrong due gfx.Rotate taking radians and not degrees. Though this should be the case in the C++ version as well so not sure what's going on there.

There's no need to have this merged to main. At the moment this is primarily for tracking compatibility issues.

Summary of changes

  • New config format, currently uses the same filename but that can be changed to be more compatible in the future.
  • gameplay cursors are 1 indexed to be consistent with lua
  • resuts gauge_type changed to gaugeType for consistent name casing.
  • diff.id instead of diff.hash due to hash not being guaranteed at song select due to support for alternate "song providers"
  • meta.json with extra skin info to potentially be used in a nicer skin picking ui in the future. (not required)
  • .luarc.json the game generates some (more to come) LuaLS annotations automatically
  • IRData is not implemented yet so added a placeholder to fix errors
  • Due to using a different Lua version, the // operator is not available.

@Drewol
Copy link
Author

Drewol commented Sep 29, 2024

Ok, I think I figured the rotation out. I think nanovg graphics are rotated by radians while "usc graphics" (labels, shadedmesh, etc) are rotated by degrees but they're both rotated by gfx.rotate. I do not want to keep this behaviour so if compability is to be maximized then it's more likely the C++ rotation being changed.

Not sure why this was an issue to begin with
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant