fix: fix memory leak

fix memory leak
add more for FreeRuntime

src/Hook/QuickJS/FreeRuntime.cs

@@ -0,0 +1,19 @@
+using Hosihikari.NativeInterop.Hook.ObjectOriented;
+using Hosihikari.VanillaScript.QuickJS.Types;
+
+namespace Hosihikari.VanillaScript.Hook.QuickJS;
+
+internal class FreeRuntime : HookBase<FreeRuntime.HookDelegate>
+{
+    internal unsafe delegate void HookDelegate(JsRuntime* rt);
+
+    public FreeRuntime()
+        : base("JS_FreeRuntime") { }
+
+    public override unsafe HookDelegate HookedFunc =>
+        rt =>
+        {
+            Loader.Manager.FreeRuntime(rt);
+            Original.Invoke(rt);
+        };
+}

src/Hook/QuickJS/NewRuntime2.cs

@@ -0,0 +1,21 @@
+using Hosihikari.NativeInterop.Hook.ObjectOriented;
+using Hosihikari.VanillaScript.QuickJS.Types;
+
+namespace Hosihikari.VanillaScript.Hook.QuickJS;
+
+internal class NewRuntime2 : HookBase<NewRuntime2.HookDelegate>
+{
+    internal unsafe delegate JsRuntime* HookDelegate(JsMallocFunctions* mf, void* opaque);
+
+    public NewRuntime2()
+        : base("JS_NewRuntime2") { }
+
+    public override unsafe HookDelegate HookedFunc =>
+        (mf, opaque) =>
+        {
+            var runtime = Original(mf, opaque);
+            Loader.Manager.AddRuntime(runtime);
+            return runtime;
+        };
+}
+//JS_FreeRuntime

src/Hook/RequestReload.cs

@@ -12,8 +12,9 @@ public RequestReload()
         public override unsafe HookDelegate HookedFunc =>
             minecraft =>
             {
-                Original.Invoke(minecraft);
                 Config.Reload();
+                Loader.Manager.FreeAllContext();
+                Original.Invoke(minecraft);
             };
     }
 }

src/Loader/Manager.cs

@@ -6,6 +6,7 @@ namespace Hosihikari.VanillaScript.Loader;
 public static partial class Manager
 {
     internal static readonly List<JsContextWrapper> LoadedScriptsContext = new();
+    internal static readonly List<JsRuntimeWrapper> LoadedScriptsRuntime = new();
 
     internal static unsafe void AddContext(JsContext* ctx, bool isLoaderContext)
     {
@@ -18,8 +19,32 @@ internal static unsafe void AddContext(JsContext* ctx, bool isLoaderContext)
         }
     }
 
+    internal static void FreeAllContext()
+    {
+        unsafe
+        {
+            foreach (var toFree in LoadedScriptsContext.ToArray())
+            {
+                try
+                {
+                    toFree.Free();
+                }
+                catch (Exception ex)
+                {
+                    Log.Logger.Error("Free JsContext " + ((nint)toFree.Context).ToString("X"), ex);
+                }
+                finally
+                {
+                    LoadedScriptsContext.Remove(toFree);
+                }
+            }
+        }
+        Log.Logger.Trace("Free All JsContext.");
+    }
+
     internal static unsafe void FreeContext(JsContext* ctx)
     {
+        Log.Logger.Trace("JsContext Free " + ((nint)ctx).ToString("X"));
         foreach (var toFree in LoadedScriptsContext.FindAll(x => x.Context == ctx).ToArray())
         {
             try
@@ -36,4 +61,30 @@ internal static unsafe void FreeContext(JsContext* ctx)
             }
         }
     }
+
+    internal static unsafe void AddRuntime(JsRuntime* rt)
+    {
+        var rtInstance = JsRuntimeWrapper.FetchOrCreate(rt); //add to LoadedScriptsRuntime
+        Log.Logger.Trace("JsRuntime Add" + ((nint)rtInstance.Runtime).ToString("X"));
+    }
+
+    internal static unsafe void FreeRuntime(JsRuntime* rt)
+    {
+        foreach (var toFree in LoadedScriptsRuntime.FindAll(x => x.Runtime == rt).ToArray())
+        {
+            try
+            {
+                Log.Logger.Trace("JsRuntime Free" + ((nint)rt).ToString("X"));
+                toFree.Free();
+            }
+            catch (Exception ex)
+            {
+                Log.Logger.Error("Free JsRuntime " + ((nint)rt).ToString("X"), ex);
+            }
+            finally
+            {
+                LoadedScriptsRuntime.Remove(toFree);
+            }
+        }
+    }
 }

src/Loader/SetupRuntime.cs

@@ -0,0 +1,13 @@
+using Hosihikari.VanillaScript.QuickJS.Wrapper;
+
+namespace Hosihikari.VanillaScript.Loader;
+
+public static partial class Manager
+{
+    public static event Action<JsRuntimeWrapper>? OnRuntimeCreated;
+
+    internal static void SetupRuntime(JsRuntimeWrapper ctx)
+    {
+        OnRuntimeCreated?.Invoke(ctx);
+    }
+}

src/Main.cs

@@ -13,7 +13,10 @@ public void Initialize(AssemblyPlugin plugin)
         new EnableScriptingHook().Install();
         new Hook.QuickJS.Eval().Install();
         new Hook.QuickJS.FreeContext().Install();
+        new Hook.QuickJS.FreeRuntime().Install();
+        new Hook.QuickJS.NewRuntime2().Install();
         new Hook.QuickJS.AddIntrinsicBaseObjects().Install();
+        new Hook.RequestReload().Install();
         new Hook.JsLog.ContextObjectBindPrint().Install();
         Assets.Prepare.Init();
     }

src/QuickJS/Helper/JsPromiseHelper.cs

@@ -41,7 +41,7 @@ public static void AwaitTask(
         Task tasks
     )
     {
-        var safeThis = new SafeJsValue(thisObj);
+        var safeThis = new SafeJsValue(thisObj, ctxPtr);
         Task.Run(async () =>
         {
             try
@@ -105,7 +105,7 @@ public static void AwaitTask<T>(
         Func<T, JsValue> fetchResult
     )
     {
-        var safeThis = new SafeJsValue(thisObj);
+        var safeThis = new SafeJsValue(thisObj, ctxPtr);
         Task.Run(async () =>
         {
             try
@@ -125,6 +125,9 @@ Func<T, JsValue> fetchResult
                                 1,
                                 &resultObj
                             );
+                            safeThis.FreeThis();
+                            promise.resolve.FreeThis();
+                            promise.reject.FreeThis();
                         }
                     }
                 });
@@ -145,6 +148,9 @@ Func<T, JsValue> fetchResult
                                 1,
                                 &reasonObj
                             );
+                            safeThis.FreeThis();
+                            promise.resolve.FreeThis();
+                            promise.reject.FreeThis();
                         }
                     }
                 });

src/QuickJS/Types/JsMallocFunctions.cs

@@ -0,0 +1,26 @@
+namespace Hosihikari.VanillaScript.QuickJS.Types;
+
+using size_t = UIntPtr;
+
+public ref struct JsMallocState
+{
+    public size_t MallocCount;
+    public size_t MallocSize;
+    public size_t MallocLimit;
+    public unsafe void* Opaque; /* user opaque */
+}
+
+public unsafe ref struct JsMallocFunctions
+{
+    //void *(*js_malloc)(JSMallocState *s, size_t size);
+    public delegate* unmanaged<JsMallocState*, nuint, void*> JsMalloc;
+
+    //void (*js_free)(JSMallocState *s, void *ptr);
+    public delegate* unmanaged<JsMallocState*, void*, void> JsFree;
+
+    //void *(*js_realloc)(JSMallocState *s, void *ptr, size_t size);
+    public delegate* unmanaged<JsMallocState*, void*, nuint, void*> JsReAlloc;
+
+    //size_t (*js_malloc_usable_size)(const void *ptr);
+    public delegate* unmanaged<void*, size_t> JsMallocUsableSize;
+}

src/QuickJS/Wrapper/AutoDropJsValue.cs

@@ -27,6 +27,10 @@ public unsafe AutoDropJsValue(JsValue value, JsContext* context)
     {
         _value = value;
         _context = context;
+        if (JsContextWrapper.TryGet((nint)context, out var tCtx))
+        {
+            tCtx.FreeContextCallback += FreeThis;
+        }
     }
 
     /// <summary>
@@ -44,24 +48,23 @@ public JsValue Steal()
 
     public void Dispose()
     {
-        ReleaseUnmanagedResources();
+        FreeThis();
         GC.SuppressFinalize(this); //prevent call ~SafeJsValue()
     }
 
     ~AutoDropJsValue()
     {
-        ReleaseUnmanagedResources();
+        FreeThis();
     }
 
     //bool _disposed = false;
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private void ReleaseUnmanagedResources()
+    private void FreeThis()
     {
         unsafe
         {
-            //if (_disposed)
-            //    return;
-            //_disposed = true;
+            if (JsContextWrapper.TryGet((nint)_context, out var tCtx))
+                tCtx.FreeContextCallback -= FreeThis;
 #if DEBUG
             //var stack = Environment.StackTrace;
             //LevelTick.PostTick(() =>

src/QuickJS/Wrapper/JsContextWrapper.cs

@@ -1,5 +1,4 @@
 using System.Diagnostics.CodeAnalysis;
-using System.Diagnostics.Contracts;
 using System.Runtime.InteropServices;
 using Hosihikari.VanillaScript.Loader;
 using Hosihikari.VanillaScript.QuickJS.Helper;
@@ -10,11 +9,12 @@ namespace Hosihikari.VanillaScript.QuickJS.Wrapper;
 public class JsContextWrapper
 {
     public unsafe JsContext* Context { get; }
-    private List<GCHandle> savedObject = new();
+    private readonly List<GCHandle> _savedObject = new();
+    public event Action? FreeContextCallback;
 
     internal void Pin(object obj)
     {
-        savedObject.Add(GCHandle.Alloc(obj));
+        _savedObject.Add(GCHandle.Alloc(obj));
     }
 
     public static unsafe implicit operator JsContextWrapper(JsContext* ctx)
@@ -57,11 +57,29 @@ public static unsafe JsContextWrapper FetchOrCreate(JsContext* ctx)
         return newInstance;
     }
 
+    private bool _freed = false;
+
+    internal void ThrowIfFree()
+    {
+        if (_freed)
+        {
+            throw new ObjectDisposedException("JsContextWrapper");
+        }
+    }
+
     internal void Free()
     {
-        foreach (var pinedItem in savedObject)
+        try
+        {
+            foreach (var pinedItem in _savedObject)
+            {
+                pinedItem.Free();
+            }
+            FreeContextCallback?.Invoke();
+        }
+        finally
         {
-            pinedItem.Free();
+            _freed = true;
         }
     }
 

src/QuickJS/Wrapper/JsRuntimeWrapper.cs

@@ -0,0 +1,65 @@
+using Hosihikari.VanillaScript.QuickJS.Types;
+using System.Diagnostics.CodeAnalysis;
+using System.Runtime.InteropServices;
+using Hosihikari.VanillaScript.Loader;
+
+namespace Hosihikari.VanillaScript.QuickJS.Wrapper;
+
+public class JsRuntimeWrapper
+{
+    public unsafe JsRuntime* Runtime { get; }
+    private readonly List<GCHandle> _savedObject = new();
+
+    internal void Pin(object obj)
+    {
+        _savedObject.Add(GCHandle.Alloc(obj));
+    }
+
+    public static unsafe implicit operator JsRuntimeWrapper(JsRuntime* rt)
+    {
+        return FetchOrCreate(rt);
+    }
+
+    private unsafe JsRuntimeWrapper(JsRuntime* rt)
+    {
+        Runtime = rt;
+        Manager.SetupRuntime(this);
+    }
+
+    public static bool TryGet(nint ctxPtr, [NotNullWhen(true)] out JsRuntimeWrapper? ctx)
+    {
+        unsafe
+        {
+            if (
+                Manager.LoadedScriptsRuntime.FirstOrDefault(x => x.Runtime == ctxPtr.ToPointer()) is
+                { } oldCtx
+            )
+            {
+                ctx = oldCtx;
+                return true;
+            }
+
+            ctx = null;
+            return false;
+        }
+    }
+
+    public static unsafe JsRuntimeWrapper FetchOrCreate(JsRuntime* ctx)
+    {
+        if (Manager.LoadedScriptsRuntime.FirstOrDefault(x => x.Runtime == ctx) is { } oldCtx)
+        {
+            return oldCtx;
+        }
+        var newInstance = new JsRuntimeWrapper(ctx);
+        Manager.LoadedScriptsRuntime.Add(newInstance);
+        return newInstance;
+    }
+
+    internal void Free()
+    {
+        foreach (var pinedItem in _savedObject)
+        {
+            pinedItem.Free();
+        }
+    }
+}