Fix unwanted behavior of NativeString when used with RegExp #11

duonglaiquang · 2024-01-04T02:30:19Z

This PR does the following:

Fix an issue when String.includes/startsWith/endsWith throw TypeError when the first argument is a regex, even if Symbol.match of that regex has been set to false.

This function is also used to identify if objects have the behavior of regular expressions. For example, the methods String.prototype.startsWith(), String.prototype.endsWith() and String.prototype.includes(), check if their first argument is a regular expression and will throw a TypeError if they are. Now, if the match symbol is set to false (or a Falsy value except undefined), it indicates that the object is not intended to be used as a regular expression object.

These tests showcase the buggy behavior of the current implementation.

<!DOCTYPE html>
<html>
<head>
<script>
var regExp = /./;
try {
  console.log("/./".includes(regExp))
} catch (e) {
  console.log(e); // TypeError: First argument to String.prototype.includes must not be a regular expression
  regExp[Symbol.match] = false;
  console.log("/./".includes(regExp)) // expected: true, got TypeError
}
</script>
</head>
<body>
</body>
</html>

…t to false

duonglaiquang · 2024-01-04T08:31:33Z

Move to #12

NativeString: fix unwanted behavior when Symbol.match of RegExp is se…

8c474ef

…t to false

duonglaiquang closed this Jan 4, 2024

duonglaiquang deleted the duong_string branch January 4, 2024 08:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix unwanted behavior of NativeString when used with RegExp #11

Fix unwanted behavior of NativeString when used with RegExp #11

Uh oh!

duonglaiquang commented Jan 4, 2024 •

edited

Loading

Uh oh!

duonglaiquang commented Jan 4, 2024

Uh oh!

Uh oh!

Fix unwanted behavior of NativeString when used with RegExp #11

Fix unwanted behavior of NativeString when used with RegExp #11

Uh oh!

Conversation

duonglaiquang commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR does the following:

These tests showcase the buggy behavior of the current implementation.

Uh oh!

duonglaiquang commented Jan 4, 2024

Uh oh!

Uh oh!

duonglaiquang commented Jan 4, 2024 •

edited

Loading