details name property support added (Chrome/Edge)

HtmlUnit · Dec 10, 2023 · d13e9f2 · d13e9f2
1 parent 6a34ea8
commit d13e9f2
Show file tree

Hide file tree

Showing 5 changed files with 382 additions and 305 deletions.
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="3.10.0" date="December xx, 2023" description="Chrome/Edge 120, Firefox 120, Bugfixes">
+            <action type="add" dev="rbri">
+                Details name property support added (Chrome/Edge).
+            </action>
             <action type="update" dev="rbri">
                 Because the naming of the method and parametes is misleading, the method
                 WebClientOptions.setSSLClientCertificate(InputStream, String, String) is deprecated. Please use

diff --git a/src/main/java/org/htmlunit/javascript/host/html/HTMLDetailsElement.java b/src/main/java/org/htmlunit/javascript/host/html/HTMLDetailsElement.java
@@ -61,4 +61,24 @@ public void setOpen(final Object newValue) {
 
         ((HtmlDetails) getDomNodeOrDie()).setOpen(bool);
     }
+
+    /**
+     * Returns the {@code name} property.
+     * @return the {@code name} property
+     */
+    @JsxGetter({CHROME, EDGE})
+    @Override
+    public String getName() {
+        return super.getName();
+    }
+
+    /**
+     * Sets the name attribute.
+     * @param newValue the new value to set
+     */
+    @JsxSetter
+    @Override
+    public void setName(final String newValue) {
+        super.setName(newValue);
+    }
 }
diff --git a/src/test/java/org/htmlunit/general/ElementOwnPropertiesTest.java b/src/test/java/org/htmlunit/general/ElementOwnPropertiesTest.java
@@ -5141,8 +5141,8 @@ public void del() throws Exception {
      * @throws Exception if the test fails
      */
     @Test
-    @Alerts(CHROME = "constructor(),open[GSCE]",
-            EDGE = "constructor(),open[GSCE]",
+    @Alerts(CHROME = "constructor(),name[GSCE],open[GSCE]",
+            EDGE = "constructor(),name[GSCE],open[GSCE]",
             FF = "constructor(),open[GSCE]",
             FF_ESR = "constructor(),open[GSCE]",
             IE = "constructor,namedRecordset(),recordset")