Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new set and get for ssl context #865

Closed
wants to merge 2 commits into from

Conversation

alexvrv
Copy link

@alexvrv alexvrv commented Sep 3, 2024

This is what I needed in #623 and #684

@rbri is there any chance that this can be merged and maybe released soon? Pretty please

@rbri
Copy link
Member

rbri commented Sep 5, 2024

Sorry for being not that responsive during the last days - was on a workshop and will be out for two more weeks to have a holiday break. Afterwards we can work together to get this finally done.

@alexvrv
Copy link
Author

alexvrv commented Sep 20, 2024

I hope your vacation went well!
Any chance that this can be included in a release this weekend?

rbri added a commit that referenced this pull request Sep 22, 2024
@rbri
Copy link
Member

rbri commented Sep 22, 2024

Hi @alexvrv,
back from vacation and the stack of work is still on my desk ;-).

Had a first look at your PR; made a small code change to always work with the sslcontext internally.

I think the sslContext should be the most important option. If this is set than we have to ignore the others and use the provided one. If not set we can fall back to the current impl. I guess this provides more flexibility.

@alexvrv what do you think?

@alexvrv
Copy link
Author

alexvrv commented Sep 22, 2024

Perfect!

@alexvrv
Copy link
Author

alexvrv commented Sep 25, 2024

@rbri Any ETA for a new release with this change? :D

@alexvrv
Copy link
Author

alexvrv commented Oct 7, 2024

@rbri Any news? ...

@rbri
Copy link
Member

rbri commented Oct 24, 2024

@alexvrv sorry for the silence - it is released...

@rbri rbri closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants