fix(ObjectUtils): only check for hashCode on truthy objects (#76)

fix(ObjectUtils): only check for hashCode on truthy objects

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 3.2.1
+* Fix shallowCompare function when one or both inputs is falsy.
+
 ## 3.2.0
 * Fix potential infinite loop with Immutable dependency values (#74)
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "general-store",
-  "version": "3.2.0",
+  "version": "3.2.1",
   "description": "Simple, flexible store implementation for Flux.",
   "main": "lib/GeneralStore.js",
   "scripts": {

src/utils/ObjectUtils.ts

@@ -68,6 +68,8 @@ export function shallowEqual(obj1: any, obj2: any): Boolean {
   // While this technically means this is deep equality for Immutables,
   // it's better to have a more specific check than an entirely incorrect one.
   if (
+    obj1 &&
+    obj2 &&
     typeof obj1.hashCode === 'function' &&
     typeof obj2.hashCode === 'function'
   ) {

src/utils/__tests__/ObjectUtils-test.js

@@ -109,5 +109,9 @@ describe('ObjectUtils', () => {
       // force hash collision - should fall back to .equals
       expect(shallowEqual(mockImmutable1, mockImmutable2)).toBe(false);
     });
+
+    it('handles immutable values if one input is falsy', () => {
+      expect(() => shallowEqual(Map({ a: 1 }), null)).not.toThrow();
+    });
   });
 });