reattempting windows build

Hugoberry · Apr 3, 2024 · 5d27734 · 5d27734
1 parent 350ec7a
commit 5d27734
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/_extension_deploy.yml b/.github/workflows/_extension_deploy.yml
@@ -22,7 +22,8 @@ on:
       exclude_archs:
         required: false
         type: string
-        default: "windows_amd64;windows_amd64_rtools"
+        default: "linux_amd64;linux_amd64_gcc4;osx_arm64;wasm_mvp;wasm_eh;wasm_threads;linux_arm64;osx_amd64;windows_amd64_rtools"
+        # default: "windows_amd64;windows_amd64_rtools"
       # Whether to upload this deployment as the latest. This may overwrite a previous deployment.
       deploy_latest:
         required: false

diff --git a/.github/workflows/_extension_distribution.yml b/.github/workflows/_extension_distribution.yml
@@ -24,8 +24,8 @@ on:
       exclude_archs:
         required: false
         type: string
-        default: "windows_amd64;windows_amd64_rtools"
-        # default: "linux_amd64;linux_amd64_gcc4;osx_arm64;wasm_mvp;wasm_eh;wasm_threads;linux_arm64;osx_amd64;windows_amd64_rtools"
+        default: "linux_amd64;linux_amd64_gcc4;osx_arm64;wasm_mvp;wasm_eh;wasm_threads;linux_arm64;osx_amd64;windows_amd64_rtools"
+        # default: "windows_amd64;windows_amd64_rtools"
       # Postfix added to artifact names. Can be used to guarantee unique names when this workflow is called multiple times
       artifact_postfix:
         required: false
@@ -306,16 +306,12 @@ jobs:
           cp $OVERLAY_TRIPLET_SRC $OVERLAY_TRIPLET_DST
           echo "set(VCPKG_PLATFORM_TOOLSET_VERSION "14.38")" >> $OVERLAY_TRIPLET_DST
 
-      - name: Set linker flags for MSVC
-        run: |
-          echo "EXT_RELEASE_FLAGS=-DCMAKE_EXE_LINKER_FLAGS='/FORCE:MULTIPLE' -DCMAKE_SHARED_LINKER_FLAGS='/FORCE:MULTIPLE'" >> $GITHUB_ENV
-
       - name: Build & test extension
         env:
           VCPKG_OVERLAY_TRIPLETS: "${{ github.workspace }}/overlay_triplets"
           DUCKDB_PLATFORM: ${{ matrix.duckdb_arch }}
         run: |
-          make test_release
+          make EXT_RELEASE_FLAGS="-DCMAKE_EXE_LINKER_FLAGS='/FORCE:MULTIPLE' -DCMAKE_SHARED_LINKER_FLAGS='/FORCE:MULTIPLE'" test_release
 
       - uses: actions/upload-artifact@v2
         with: