Skip to content

Commit

Permalink
ignore windows build
Browse files Browse the repository at this point in the history
  • Loading branch information
Hugoberry committed Apr 2, 2024
1 parent 3b5e25a commit 9b8cb17
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/_extension_distribution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ on:
exclude_archs:
required: false
type: string
default: "linux_amd64;linux_amd64_gcc4;osx_arm64;wasm_mvp;wasm_eh;wasm_threads;linux_arm64;osx_amd64;windows_amd64_rtools"
default: "windows_amd64;windows_amd64_rtools"
# default: "linux_amd64;linux_amd64_gcc4;osx_arm64;wasm_mvp;wasm_eh;wasm_threads;linux_arm64;osx_amd64;windows_amd64_rtools"
# Postfix added to artifact names. Can be used to guarantee unique names when this workflow is called multiple times
artifact_postfix:
required: false
Expand Down
6 changes: 3 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ set(TARGET_NAME pbix)
# Note that it should also be removed from vcpkg.json to prevent needlessly installing it..
# find_package(OpenSSL REQUIRED)
# find_package(tinyxml2 REQUIRED)
# find_package(unofficial-sqlite3 REQUIRED)
find_package(unofficial-sqlite3 REQUIRED)
find_package(Crc32c REQUIRED)
find_package(miniz REQUIRED)

Expand Down Expand Up @@ -65,7 +65,7 @@ build_loadable_extension(${TARGET_NAME} " " ${EXTENSION_SOURCES})

# Right after defining and linking libraries to ${EXTENSION_NAME}
# target_link_libraries(${EXTENSION_NAME} tinyxml2::tinyxml2)
# target_link_libraries(${EXTENSION_NAME} unofficial::sqlite3::sqlite3)
target_link_libraries(${EXTENSION_NAME} unofficial::sqlite3::sqlite3)
target_link_libraries(${EXTENSION_NAME} Crc32c::crc32c)
target_link_libraries(${EXTENSION_NAME} Threads::Threads)
target_link_libraries(${EXTENSION_NAME} miniz::miniz)
Expand All @@ -74,7 +74,7 @@ target_link_libraries(${EXTENSION_NAME} miniz::miniz)

# And similarly for ${LOADABLE_EXTENSION_NAME}
# target_link_libraries(${LOADABLE_EXTENSION_NAME} tinyxml2::tinyxml2)
# target_link_libraries(${LOADABLE_EXTENSION_NAME} unofficial::sqlite3::sqlite3)
target_link_libraries(${LOADABLE_EXTENSION_NAME} unofficial::sqlite3::sqlite3)
target_link_libraries(${LOADABLE_EXTENSION_NAME} Crc32c::crc32c)
target_link_libraries(${LOADABLE_EXTENSION_NAME} Threads::Threads)
target_link_libraries(${LOADABLE_EXTENSION_NAME} miniz::miniz)
Expand Down
1 change: 1 addition & 0 deletions vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"dependencies": [
"sqlite3",
"miniz",
"crc32c"
]
Expand Down

0 comments on commit 9b8cb17

Please sign in to comment.