Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added transplant_organ field in specimen_from_organism. Fixes #1547 #1548

Merged
merged 12 commits into from
Mar 22, 2024
Merged

Added transplant_organ field in specimen_from_organism. Fixes #1547 #1548

merged 12 commits into from
Mar 22, 2024

Conversation

arschat
Copy link
Collaborator

@arschat arschat commented Feb 16, 2024 •
edited
Loading

Release notes

For type/biomaterial/specimen_from_organism schema:

  • added transplant_organ field

Reviews requested

@arschat arschat changed the title Added organ_donor field in donor_organism. Fixes#1547 Added organ_donor field in donor_organism. Fixes #1547 Feb 16, 2024
@arschat arschat mentioned this pull request Feb 16, 2024
Closed
ESapenaVentura
ESapenaVentura requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@ESapenaVentura ESapenaVentura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this field would be better suited in the Specimen, given multiple specimens can be taken from a donor and not all of them may come from a transplanted organ

@arschat arschat changed the title Added organ_donor field in donor_organism. Fixes #1547 Added organ_donor field in specimen_from_organism. Fixes #1547 Mar 8, 2024
@hannes-ucsc
Copy link
Contributor

Note that these are questions/suggestions, not requested changes.

@arschat arschat changed the title Added organ_donor field in specimen_from_organism. Fixes #1547 Added transplant_organ field in specimen_from_organism. Fixes #1547 Mar 12, 2024
@hannes-ucsc hannes-ucsc mentioned this pull request Mar 18, 2024
Closed
ESapenaVentura
ESapenaVentura approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@ESapenaVentura ESapenaVentura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Let me know if you need assistance solving the conflicts

@arschat arschat merged commit b119b1a into staging Mar 22, 2024
3 of 5 checks passed
@arschat arschat deleted the ac-organ-donor-Issue1547 branch March 22, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ESapenaVentura ESapenaVentura ESapenaVentura approved these changes

@hannes-ucsc hannes-ucsc hannes-ucsc approved these changes

@NoopDog NoopDog NoopDog approved these changes

@amnonkhen amnonkhen amnonkhen approved these changes

@ncalvanese1 ncalvanese1 Awaiting requested review from ncalvanese1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arschat @hannes-ucsc @amnonkhen @NoopDog @ESapenaVentura @ncalvanese1 @idazucchi