Fix PosixPath being passed to HuggingFace save_to_disk (which does not accept it)
#855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as str, bytes or os.PathLike. imitation.util.parse_path always returned pathlib.Path which is not one of these types. This commit converts pathlib.Path to str before calling the HF fn.
Jaramyy
reviewed
Oct 11, 2024
| trajectories: The trajectories to save. | ||
| """ | ||
| p = util.parse_path(path) | ||
| p = str(util.parse_path(path)) |
There was a problem hiding this comment.
I tested with this solution. It works.
Collaborator
|
Fixed in #831 (comment) before I saw this PR, won't close this because the unit tests may be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HuggingFace save_to_disk takes
PathLiketype which is defined as str, bytes or os.PathLike. imitation.util.parse_path always returned pathlib.Path which is not one of these types. This commit converts pathlib.Path to str before calling HuggingFace save_to_disk.Related issue #852
Testing
Passed a path in both
strandPathforms tosaveforTrajectoryandTrajectoryWithRew.Expanded testing of serialize by adding additionalsavethenloadtests.