Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OPTIC-1242: Ask new OSS installs how they found about us #6655

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

yyassi-heartex
Copy link
Contributor

@yyassi-heartex yyassi-heartex commented Nov 14, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

adding an optional field on signup to ask how the new user heard about Label Studio
updated signup will look like this:
image

Copy link

sentry-io bot commented Nov 14, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: label_studio/users/functions.py

Function Unhandled Issue
save_user Exception: Unauthorized operation /user/signup/
Event Count: 1
📄 File: label_studio/users/views.py (Click to Expand)
Function Unhandled Issue
user_signup Exception: Unauthorized operation /user/signup/
Event Count: 1
---

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the feat label Nov 14, 2024
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 8004bea
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/673b4cfeabadd800083b6e8f

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 8004bea
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/673b4cfd63abd500080f53db

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (fc49438) to head (8004bea).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/users/forms.py 88.88% 1 Missing ⚠️
label_studio/users/functions.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6655   +/-   ##
========================================
  Coverage    76.76%   76.77%           
========================================
  Files          169      169           
  Lines        13865    13876   +11     
========================================
+ Hits         10644    10653    +9     
- Misses        3221     3223    +2     
Flag Coverage Δ
pytests 76.77% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented Nov 18, 2024

/git merge develop

Workflow run
Successfully merged: 8 files changed, 26 insertions(+), 72 deletions(-)

Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a print statement to remove, rest looks good!

yyassi-heartex and others added 2 commits November 18, 2024 09:17
Co-authored-by: bmartel <brandonmartel@gmail.com>
@yyassi-heartex yyassi-heartex merged commit 52aea5b into develop Nov 18, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants