Fix #1585: Add missing DataUnit and TimeUnit translations for Portuguese (pt) and Brazilian Portuguese (pt-BR) #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Portuguese (pt) and Brazilian Portuguese (pt-BR)
…ian Portuguese (pt-BR)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing localization resources for Portuguese (pt) and Brazilian Portuguese (pt-BR) to fix issue #1585. The changes add DataUnit and TimeUnit translation keys that were previously missing, enabling proper localization of byte sizes and time unit symbols.
Changes:
- Added DataUnit resource keys (Bit, Byte, Kilobyte, Megabyte, Gigabyte, Terabyte and their symbols) to Portuguese resource files
- Added TimeUnit resource keys (Millisecond, Second, Minute, Hour, Day, Week, Month, Year) to Portuguese resource files
- Added comprehensive xUnit tests for both locales covering ByteSizeExtensions and TimeUnitToSymbol functionality
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Humanizer/Properties/Resources.pt.resx | Added DataUnit and TimeUnit resource entries with Portuguese translations and helpful comments |
| src/Humanizer/Properties/Resources.pt-BR.resx | Added DataUnit and TimeUnit resource entries with Brazilian Portuguese translations and helpful comments |
| src/Humanizer.Tests/Localisation/pt/TimeUnitToSymbolTests.cs | New test file validating TimeUnit symbol translations for pt culture |
| src/Humanizer.Tests/Localisation/pt/Bytes/ByteSizeExtensionsTests.cs | New test file validating byte size humanization for pt culture |
| src/Humanizer.Tests/Localisation/pt-BR/TimeUnitToSymbolTests.cs | New test file validating TimeUnit symbol translations for pt-BR culture |
| src/Humanizer.Tests/Localisation/pt-BR/Bytes/ByteSizeExtensionsTests.cs | New test file validating byte size humanization for pt-BR culture |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1585
Added missing
DataUnit_*andTimeUnit_*resource keys toResources.pt.resxandResources.pt-BR.resx.Changes:
Resources.pt.resxandResources.pt-BR.resxwith Portuguese translations.src/Humanizer.Tests/Localisation/pt/andsrc/Humanizer.Tests/Localisation/pt-BR/coveringByteSizeExtensionsandTimeUnitToSymbol.Verified: