Skip to content

Conversation

@andeston
Copy link
Contributor

No description provided.

@Hummer12007
Copy link
Owner

Hummer12007 commented Dec 10, 2024

Why (apart from the fix)?

@andeston
Copy link
Contributor Author

Why (apart from the fix)?

Short answer is I don't really remember.

d6e5d18: I think this didn't fully fix the problem on it's own. The other changes were for fixing bugs caused by that change, XDG Base Directory Specification compliance, simplification, and readability.

af938fb: ensure_dev_dir and ensure_run_dir basically only called ensure_dir

09d9e49: mkdir_parent is more generic and, IMO, more useful.

6fee015: Honestly, this one might be mostly a style thing. I don't like goto. I think it should be avoided unless absolutely necessary. For me, this is more readable and more clearly indicates intent. You may disagree, and that's fine.

3b7b63b: converting from binary to text and from text back to binary is completely unnecessary.

412c991: Permissions.

8eea9f5: Permissions.

Let me know if you have other questions/concerns about any of the commits.

Thanks and welcome back.

@Hummer12007
Copy link
Owner

Thanks, I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants