Major refactor, use statsmodels instead of R 🎉, fixes #55 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[NEW] added a convenience class util.pdf_writer which writes
once, then sleeps for 2 seconds, then writes again. Motivated
by the solution here plotly/plotly.py#3469
we only have to do this sleep once, during a session. So we create
an instance of this writer and use it for all writes.
[CHANGED] we remove all rpy2 code and do the log-linear modelling
using statsmodels. Nice!
[CHANGED] defined a loglin_result dataclass for providing results,
plus unified the spectra and neighbour effect models
[CHANGED] not being used
GavinHuttley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.