Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make several crimes against the clear commands #348

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Conversation

NoComment1105
Copy link
Member

Fixes #346

This all works pretty much first try so it's voodoo code i will never ever look at again. Please review! :D

@NoComment1105 NoComment1105 added the T: feature enhancement Suggests an improvement to an existing feature label May 9, 2023
Copy link
Member

@tempest15 tempest15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused about what the message count argument does on the clear between command. Seems like it just does the latest, so seems redundant with clear before/after.

We might want some sort of maximum because I did successfully delete 100 messages but it took a while.

What does clear before without a count argument do? Seems dangerous. Just generally, I think it might be good to have some sort of safety mechanism to cancel the process, no clue if that's at all possible.

You do need to clear up conflicts, but functionality looks good, sorry for taking so long to get to it.

@NoComment1105 NoComment1105 changed the base branch from main to develop September 4, 2023 07:29
# Conflicts:
#	src/main/kotlin/org/hyacinthbots/lilybot/extensions/moderation/ModerationCommands.kt
@NoComment1105
Copy link
Member Author

Yeah looks like that count argument was redundant in the between command.

The maximum discord allows is 100. I can reduce it if you feel it necessary.

All commands have a maximum delete count of 100 as that's the discord limit, so there should be no issue if before is used and no count argument specified

Copy link
Member

@tempest15 tempest15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@NoComment1105 NoComment1105 merged commit 149e53b into develop Sep 5, 2023
2 checks passed
@NoComment1105 NoComment1105 deleted the clear-crimes branch September 5, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature enhancement Suggests an improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear a range of messages
2 participants