Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to official mongo driver #351

Merged
merged 11 commits into from
Sep 8, 2023
Merged

Switch to official mongo driver #351

merged 11 commits into from
Sep 8, 2023

Conversation

NoComment1105
Copy link
Member

This caused me physical pain.

@NoComment1105 NoComment1105 added the PRT: refactor This is a refactor of the codebase label Aug 22, 2023
tempest15
tempest15 requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@tempest15 tempest15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should set up constants for collection names somewhere rather than typing the string out each time. Seems safer, dunno why Mongo made it that way.

@NoComment1105
Copy link
Member Author

Yep that's do-able, kord-ex and cozy use a system that makes that possible, I'll look into adding that

tempest15
tempest15 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@tempest15 tempest15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very elegant, nice

@NoComment1105 NoComment1105 merged commit 8557d4f into develop Sep 8, 2023
2 checks passed
@NoComment1105 NoComment1105 deleted the switch-to-official-mongo-driver branch September 8, 2023 18:03
NoComment1105 added a commit that referenced this pull request Sep 13, 2023
@NoComment1105
Revert "Switch to official mongo driver (#351)"
d76bc5c 
This reverts commit 8557d4f
NoComment1105 added a commit that referenced this pull request Sep 18, 2023
@NoComment1105
Revert "Revert "Switch to official mongo driver (#351)""
f2f2322 
This reverts commit d76bc5c.
NoComment1105 added a commit that referenced this pull request Sep 18, 2023
@NoComment1105
Develop (#356)
183f4d5 
* Revert "Revert "Switch to official mongo driver (#351)""

This reverts commit d76bc5c.

* Revert "Revert "Fix getting some elements from the database""

This reverts commit 2b0e6f7.

* Remove unneeded database reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tempest15 tempest15 tempest15 approved these changes

Assignees
No one assigned
Labels
PRT: refactor This is a refactor of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoComment1105 @tempest15