Open
Conversation
- Modified CsvEnsembleReader.java to accept suffix parameter for flexible filename patterns - Restructured test resources into watershed-specific directories (FeatherYuba/, Kanektok/) - Updated TestingPaths.java to dynamically build paths for reorganized structure - Enhanced Testing.java bulk testing to validate multiple watershed patterns - Updated various test classes to work with new directory structure - Organized existing Kanektok test files into subdirectory
ffbc01c to
6f093ed
Compare
ktarbet
reviewed
Feb 23, 2026
Collaborator
ktarbet
left a comment
There was a problem hiding this comment.
Looks good! I've added a couple suggestions.
|
|
||
| /** | ||
| * | ||
| * @param path path to csv file cache (example C:\Temp\hefs_cache) |
Collaborator
There was a problem hiding this comment.
consider updating java doc.
Suggested change
| * @param path path to csv file cache (example C:\Temp\hefs_cache) | |
| * @param path path to csv file cache (example C:\Temp\hefs_cache) | |
| * | |
| * @param suffix for csv file (not including .csv) |
Collaborator
There was a problem hiding this comment.
Please add an overloaded constructor for users that are using this the old way.
public CsvEnsembleReader(String path) {
this.suffix="";
this.pathToCSV = path;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Support for Non-Standard CSV Filename Patterns
This PR enhances the CSV ensemble reader to handle files with non-standard naming conventions, improving flexibility for different watershed data sources.
🚀 Key Features
CsvEnsembleReaderconstructor to support different CSV file naming conventions📁 Changes Made
Core Implementation:
CsvEnsembleReader.javato accept suffix parameter for flexible filename patternsTest Infrastructure Updates:
FeatherYuba/,Kanektok/)TestingPaths.javato dynamically build paths for reorganized structureTesting.javabulk testing to validate multiple watershed patternsTest Data:
✅ Testing