Open
Conversation
…tations; introduce SingleValueComputable and SingleTimeSeriesComputable interfaces, and update related classes and tests accordingly. - Implement new ComputableIndex class - PercentileComputableIndex - This Class contains a helper class ValueIndexPair to support tracking the original unsorted n-day volume index after they get sorted to calculate a percentile. - refactor SingleComputable to SingleValueComputable to allow for a new class SingleTimeSeriesComputable which differentiates between float and float[] return datatypes. - Implement TwoStepComputableSingleMetricTimeSeries which was based upon TwoStepComputableSingleMetricValue - Implement new method computeSingleValueSummaryTimeSeries was implemented in EnsembleTimeSeries.java - Add unit test testMetricCollectionAsTimeSeries_TwoStep() was added to MetricCollectionTimeSeriesUnitsTest.java
danhamill
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #257
This PR is conceptually similar to
getClosestVolEnsembleMemberfrom the rts-forecast-processor-plugin but is implemented here to work within the SQLite database format.Two classes were added to support returning the ensemble member hydrograph representing a two step statistical metric.
ComputableIndexClassPercentileComputableIndex- This Class contains a helper classValueIndexPairto support tracking the original unsorted n-day volume index after they get sorted to calculate a percentile.To implement these classes I refactored
SingleComputabletoSingleValueComputableto allow for a new classSingleTimeSeriesComputablewhich differentiates betweenfloatandfloat[]return datatypes.The calculation is actually completed in
TwoStepComputableSingleMetricTimeSerieswhich was based uponTwoStepComputableSingleMetricValue(formerly namedTwoStepComputable).A new method
computeSingleValueSummaryTimeSerieswas implemented inEnsembleTimeSeries.javaThe unit test
testMetricCollectionAsTimeSeries_TwoStep()was added toMetricCollectionTimeSeriesUnitsTest.java