TEL - Create Latency Node #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomLonergan03
requested changes
Jul 2, 2024
|
|
||
| const auto payload = nextMessage->payload; | ||
| const auto topic = core::MqttTopic::kLatencyResponse; | ||
| const core::MqttMessage::Header header{.timestamp = 0, |
There was a problem hiding this comment.
you need a WallClock as a data member, then:
.timestamp = time_.now().time_since_epoch().count()
| } | ||
|
|
||
| void Latency::run() | ||
| { |
There was a problem hiding this comment.
while (true) otherwise this runs once lol
| @@ -152,7 +152,7 @@ export const PodsProvider = ({ children }: { children: React.ReactNode }) => { | |||
| publish( | |||
| 'latency/request', | |||
| JSON.stringify({ | |||
| latency: new Date().getTime().toString(), | |||
| timestamp: new Date().getTime().toString(), | |||
There was a problem hiding this comment.
here and elsewhere, are you remembering that all mqtt messages are of the format:
{
header : {
timestamp: int,
priority: int
},
payload: { rest of data }
}There was a problem hiding this comment.
Ahhh I see. Will need to change this throughout the telemetry code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.