Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM - States and Transitions #23

Merged
merged 11 commits into from
Nov 15, 2023
Merged

STM - States and Transitions #23

merged 11 commits into from
Nov 15, 2023

Conversation

DH254
Copy link
Contributor

@DH254 DH254 commented Nov 2, 2023

Updated states to match the 2024 plans for the state machine.
Updated tests to match.

TomLonergan03
TomLonergan03 requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@TomLonergan03 TomLonergan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very good, especially for a first PR! Mostly just nitpicks

lib/state_machine/message.hpp Outdated Show resolved Hide resolved
lib/state_machine/state.hpp Outdated Show resolved Hide resolved
lib/state_machine/state_machine.cpp Outdated Show resolved Hide resolved
lib/state_machine/state.hpp Outdated Show resolved Hide resolved
DylanCavers
DylanCavers reviewed Nov 6, 2023
View reviewed changes
lib/state_machine/state_machine.hpp Outdated Show resolved Hide resolved
test/state_machine/stm_tests.cpp Outdated Show resolved Hide resolved
TomLonergan03
TomLonergan03 requested changes Nov 6, 2023
View reviewed changes
test/state_machine/stm_tests.cpp Outdated Show resolved Hide resolved
test/state_machine/stm_tests.cpp Show resolved Hide resolved
DylanCavers
DylanCavers reviewed Nov 9, 2023
View reviewed changes
lib/state_machine/state_machine.hpp Outdated Show resolved Hide resolved
test/state_machine/stm_tests.cpp Outdated Show resolved Hide resolved
DylanCavers
DylanCavers approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@DylanCavers DylanCavers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

TomLonergan03
TomLonergan03 requested changes Nov 9, 2023
View reviewed changes
lib/state_machine/state_machine.hpp Show resolved Hide resolved
lib/state_machine/types.hpp Outdated Show resolved Hide resolved
TomLonergan03
TomLonergan03 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@TomLonergan03 TomLonergan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TomLonergan03 TomLonergan03 merged commit 85cae19 into master Nov 15, 2023
8 checks passed
@TomLonergan03 TomLonergan03 deleted the stm_changes branch November 15, 2023 11:36
@DylanCavers DylanCavers mentioned this pull request Nov 15, 2023
Merged
9 tasks
licornes-fluos pushed a commit that referenced this pull request Jan 27, 2024
@DH254 @licornes-fluos
STM - States and Transitions (#23)
5f12b42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanCavers DylanCavers DylanCavers approved these changes

@TomLonergan03 TomLonergan03 TomLonergan03 approved these changes

Assignees

@DH254 DH254

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DH254 @TomLonergan03 @DylanCavers