Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the RELEASE.md file with the latest instructions #2239

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

diegolovison
Copy link
Contributor

Fixes Issue

Closes #2165

Changes proposed

Update the RELEASE.md file with the latest instructions. Due to that previous content was entirely removed. It will be easy to review if you open the rendered version in a new tab.
image

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr lampajr self-requested a review January 15, 2025 17:06
Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @diegolovison, overall looks great!
I left just a couple of changes that I think it would be great to have

docs/DEVELOPMENT.md Outdated Show resolved Hide resolved
docs/RELEASE.md Show resolved Hide resolved
diegolovison and others added 2 commits January 15, 2025 14:38
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
@diegolovison
Copy link
Contributor Author

Accepted the suggestion by doing the commit via UI. I think it will be good to Squash and Merge. I don't know if you will be kept as author. I only would like to not have 3 commits for a single change.

Thanks

@lampajr lampajr merged commit d6087c2 into Hyperfoil:master Jan 15, 2025
2 checks passed
@diegolovison diegolovison deleted the improve_release branch January 15, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release documentation
2 participants