Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the StateMachine implementation to remove the virtual set_on method from the IStateMachine interface and transitions from a runtime-based nested machine management approach to a compile-time tuple-based approach. The changes improve type safety and potentially performance by leveraging compile-time configuration.
Changes:
- Removed
is_onfield andset_on()virtual method from StateMachine and its interface - Replaced
FixedVectortype alias with directStaticVectorusage - Introduced compile-time tuple-based nested machine management with
NestedMachineBindingand helper functions - Added self-transition validation in State constructor
- Refactored state change logic into a single
perform_state_change()method - Updated HeapStateOrder and StackStateOrder to remove
is_onchecks
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Inc/ST-LIB_LOW/StateMachine/StateMachine.hpp | Core refactoring: removed is_on/set_on, replaced dynamic nested machines with compile-time tuple approach, added self-transition validation, introduced StateMachineHelper namespace |
| Inc/ST-LIB_LOW/StateMachine/StackStateOrder.hpp | Removed is_on checks from process() and parse() methods |
| Inc/ST-LIB_LOW/StateMachine/HeapStateOrder.hpp | Removed is_on checks from process() and parse() methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.