refactor(logger): improve structure, fix issues and add test coverage#384
Merged
Humanoidear merged 25 commits intodevelopfrom Nov 14, 2025
Merged
refactor(logger): improve structure, fix issues and add test coverage#384Humanoidear merged 25 commits intodevelopfrom
Humanoidear merged 25 commits intodevelopfrom
Conversation
…ch respective module after refactor
Humanoidear
approved these changes
Nov 14, 2025
Contributor
Humanoidear
left a comment
There was a problem hiding this comment.
All tests pass on my machine, logger appears to work properly in the ethernet view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
BaseLogger
A new logger
baseLoggerthat contains the logic of manage internal time, and start, stop. It also contains create file function.NewBaseLogger(): creates abaseLoggerto be used for compositionStart(): starts the logger and updates start timeCreateFile(): given a path creates a file and returns a pointer to a filePullRecord(): common implementation of PullRecord, right now only panicsStop(): template function that given a procedure to stop a logger it executes it (first order logic)orderLogger,dataLoggerandprotectionLoggerinherit* by composition this functions, some subloggers might overwrite the functions ofbaselogger.Main
Remove
stateLoggerandprotectionsLoggerbecause they are no longer used acording to @JFisica .Test
Create unit test for all the subloggers, except
stateLoggerandprotectionsLogger.Fix
Modify
dataLoggerto allow having different boards monitoring variables with the same name.