-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hyperbunTableForType for pointer types #3
Conversation
WalkthroughThe recent updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Code
participant Reflection
User->>Code: Call Upsert with a pointer type
Code->>Reflection: Call hyperbunTableForType[*T]()
Reflection->>Code: Return extracted element type
Code->>User: Complete Upsert
Assessment against linked issues
Poem
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- hyperbun.go (1 hunks)
- hyperbun_test.go (1 hunks)
Additional comments not posted (2)
hyperbun_test.go (1)
21-23
: LGTM!The test function
TestHyperbunTableForPtrType
correctly tests thehyperbunTableForType
function with a pointer type.hyperbun.go (1)
436-439
: LGTM!The function
hyperbunTableForType
has been correctly updated to handle pointer types by extracting the element type before processing.
This fixes https://github.com/Hypersequent/tms-issues/issues/498
Summary by CodeRabbit
Bug Fixes
hyperbunTableForType
function to correctly process pointer types.Tests
hyperbunTableForType
function.