Share belongs_to cache
#4264
Merged
Share belongs_to cache
#4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
approved these changes
Feb 11, 2025
tybug
force-pushed
the
belongs-to-cache
branch
from
b1df522 to
bb13466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also renames all (?) remaining references to
ir_.ChoiceNode(type="integer")is maybe a bit weird butChoiceNode(choice_type="integer")felt too verbose. I think ofchoiceas "a single typed value" andChoiceNodeas "a value plus the context in which it was drawn (kwargs/etc)".Things were looking pretty hairy for a while when we were in the thick of the migration, api-design and naming-wise 😅 I'm pretty happy with where we've ended up in
choice.pynow though.