-
Notifications
You must be signed in to change notification settings - Fork 630
Update base CI version to 3.14 (from 3.10) #4512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…without a blank line; unexpected unindent"
136185a to
caf6eba
Compare
|
we've found a fair few cpython issues in other ways too 😅 |
| "integer_array_indices(shape=(2, 3))", | ||
| "tuple[ndarray[tuple[int, ...], dtype[signedinteger[Any]]], ...]", | ||
| "tuple[ndarray[tuple[Any, ...], dtype[signedinteger[Any]]], ...]", | ||
| ), | ||
| ( | ||
| 'integer_array_indices(shape=(2, 3), dtype=np.dtype("int32"))', | ||
| "tuple[ndarray[tuple[int, ...], dtype[signedinteger[_32Bit]]], ...]", | ||
| "tuple[ndarray[tuple[Any, ...], dtype[signedinteger[_32Bit]]], ...]", | ||
| ), | ||
| ( | ||
| 'integer_array_indices(shape=(2, 3), dtype=np.dtype("uint8"))', | ||
| "tuple[ndarray[tuple[int, ...], dtype[unsignedinteger[_8Bit]]], ...]", | ||
| "tuple[ndarray[tuple[Any, ...], dtype[unsignedinteger[_8Bit]]], ...]", | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see numpy/numpy#29830, numpy loosened these types in 2.3
|
I ran into a transitive dependency issue specific to 3.13 that would have been a pain to work around, so I'm bumping everything to 3.14 instead |
Zac-HD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny comments, merge at will!
I ran into a CPython bug while working on this: python/cpython#137841. That's now the second CPython bug our CI has found by running our test suite with weird command line flags! (The other one: python/cpython#137308).