-
Notifications
You must be signed in to change notification settings - Fork 34
Gh-6: Migrade to gradle #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I beleive the how setup logic belongs into a gradle plugin, not build.gradle, but I think, it is fine for now. |
|
Does this include the change in #5 |
|
No, it does not, I will add the needed replacers |
|
Please do so and remove the merge conflicts (rebase the most recent commit on your branch) |
# Conflicts: # pom.xml
9abb9c6 to
bac349b
Compare
|
@ItsNeil17 I'm not that fast... You just created the confilct by merging #5 xD |
60ecf27 to
bd8f971
Compare
|
Well that should do it... |
|
Not sure that this was not on the repository yet, this is the change I was talking about, you might have to redo some parts, sorry! |
|
Well I replaced the json thing form the other repo with blossom since the custom func was not building because of some serialization build cache error. |
|
Also it was not my goal to migrate this repo to kotlin, the other had the hole kotlin std lib inside |
|
Ahh I see, it was migrated into a plugin...
Seems to be this repo: |
|
@ItsNeil17 It is now migrated to the hytale gradle plugin |
thank you! |
|
Can't merge this yet because the guide also needs to be updated, will update that tomorrow and merge both of these together. |
ItsNeil17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hytale's server.jar is available on Maven now. Please update this!
Implements #6 gh-6