Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gvl data category mapping #180

Merged
merged 1 commit into from
Oct 12, 2023
Merged

update gvl data category mapping #180

merged 1 commit into from
Oct 12, 2023

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Oct 12, 2023 •
edited
Loading

Closes https://ethyca.atlassian.net/browse/PROD-1175

Description Of Changes

Updates data category mapping per ticket

Code Changes

  • update static mapping file
  • update tests

Steps to Confirm

  • automated tests give us coverage we need 👍

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@adamsachs adamsachs self-assigned this Oct 12, 2023
@adamsachs adamsachs requested a review from pattisdr October 12, 2023 16:08
@adamsachs adamsachs marked this pull request as ready for review October 12, 2023 16:08
@adamsachs
Copy link
Contributor Author

i'll update the changelog on my other PR with this, i promise 😄

@adamsachs adamsachs requested a review from rsilvery October 12, 2023 16:14
pattisdr
pattisdr approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified matches mapping in ticket 👍

@adamsachs adamsachs merged commit 6facbce into main Oct 12, 2023
31 checks passed
@adamsachs adamsachs deleted the asachs/PROD-1175-update-data-category-mapping branch October 12, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattisdr pattisdr pattisdr approved these changes

@rsilvery rsilvery Awaiting requested review from rsilvery

Assignees

@adamsachs adamsachs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamsachs @pattisdr