UID2-3243 token lifetime check fix for token v2 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asloobq
approved these changes
Apr 23, 2024
| callAndVerifyRefreshJson(identityScope); | ||
| public void smokeTestForBidstream(IdentityScope identityScope, TokenVersionForTesting tokenVersion) throws Exception { | ||
| Instant now = Instant.now(); | ||
| String advertisingToken = AdvertisingTokenBuilder.builder().withScope(identityScope).withVersion(tokenVersion).withEstablished(now.minus(120, ChronoUnit.DAYS)).withGenerated(now.plus(-1, ChronoUnit.DAYS)).withExpiry(now.plus(2, ChronoUnit.DAYS)).build(); |
There was a problem hiding this comment.
nitpick: better to say now.minus(1, ChronoUnit.DAYS) instead of now.plus(-1, ChronoUnit.DAYS)
| callAndVerifyRefreshJson(identityScope); | ||
| public void smokeTestForBidstream(IdentityScope identityScope, TokenVersionForTesting tokenVersion) throws Exception { | ||
| Instant now = Instant.now(); | ||
| String advertisingToken = AdvertisingTokenBuilder.builder().withScope(identityScope).withVersion(tokenVersion).withEstablished(now.minus(120, ChronoUnit.DAYS)).withGenerated(now.plus(-1, ChronoUnit.DAYS)).withExpiry(now.plus(2, ChronoUnit.DAYS)).build(); |
There was a problem hiding this comment.
120 days in the past is unrealistic for bidstream tokens. Probably 3 days in the past is normal
There was a problem hiding this comment.
Not true, we actually get tokens that are generated months ago and are refreshed regularly. That's why we're making this PR. Feel free to add that as a comment if it's not clear though.
There was a problem hiding this comment.
that's right. I mixed up established and generated
jon8787
approved these changes
Apr 24, 2024
caroline-ttd
deleted the
ccm-UID2-3243-token-lifetime-check-fix-for-token-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token lifetime check fix for token v2.
Did Unit tests & integration tests locally.