Support Domain or App name check in bidstream client #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asloobq
commented
Oct 8, 2024
•
asloobq
commented
- Domain name / App name check will be enforced while decrypting tokens by BidStreamClient if the tokens have been generated at Client Side
- Check will be skipped for
- SharingClient
- Legacy client (UID2Client)
- Token generated at Server side
- Introducing lombok as a dependency
jon8787
reviewed
Oct 9, 2024
pom.xml
Outdated
| @@ -66,6 +66,12 @@ | |||
| <artifactId>junit-jupiter-params</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
I don't think Lombok's approved for use in the SDKs, but could you investigate?
There was a problem hiding this comment.
ideally don't include it - i think we need to add lombok license in this repo before we can do it
sunnywu
approved these changes
Oct 9, 2024
sunnywu
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.