Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vuln scanning to test pipeline #30

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

gmsdelmundo
Copy link
Contributor

No description provided.

@gmsdelmundo gmsdelmundo force-pushed the gdm-UID2-3154-secret-scanning branch from 4cd0ffd to 6aba4ff Compare April 29, 2024 07:34
@gmsdelmundo gmsdelmundo force-pushed the gdm-UID2-3154-secret-scanning branch from 6aba4ff to 0c94a54 Compare April 29, 2024 07:37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of change here - how are you testing this? Is it required as part of the vulnerability scanning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, tested the Docker image against integ operator
And yes, packages need to be updated to fix vulnerabilities

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this file - seems a lot of changes to introduce vulnerability scanning. Need to confirm this has been tested

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, tested the Docker image against integ operator

Copy link
Contributor

@thomasm-ttd thomasm-ttd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@gmsdelmundo gmsdelmundo merged commit aa41bee into main Apr 30, 2024
2 checks passed
@gmsdelmundo gmsdelmundo deleted the gdm-UID2-3154-secret-scanning branch April 30, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants