ngOnDestroy in gp-translate.directive.ts #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

vmukhachev wants to merge 1 commit into IBM-Cloud:master from vmukhachev:patch-1

vmukhachev commented Oct 17, 2019 •

edited

Loading

Hello,
Shouldn't you call the this.onLangChangeSub.unsubscribe(); in the directive the same way as in the pipe?

P.S.
Perhaps, it would be even better if it does not create the subscription.


          Update gp-translate.directive.ts

4a3dc2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet