Amrut - Fix for Non s390x install config architecture #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmadeusPodvratnik
requested changes
Jul 2, 2025
Collaborator
AmadeusPodvratnik
left a comment
AmadeusPodvratnik
left a comment
There was a problem hiding this comment.
Hi @amrutp-redhat Thank you for the PR.
Did you check the defaults and there the mechanics how default variables are set (See folder /defaults and /vars). Some of the variables are flatten - see the docs - so if you run into an error because you set env.install_config ... than this is expected and you need to specify install_config.... in your all.yaml.
Pls revalidate your PR.
In addition you should specify "fix:" as prefix for your PR.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when trying to install x86 ocp cluster install config take s390x. I should be read from all.yaml install config architecture