-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App to test network connectivity to CE services #133
App to test network connectivity to CE services #133
Conversation
128af89
to
79e5720
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on this app, which will surely help clients and us to identify connectivity issues. I am looking forward to get this in.
Besides the two comments that I made, I suggest to also add a README which briefly describes what this sample is about and how it can be used (e.g. how should PG creds be configured)
Furthermore, I suggest to add a file called build
, which contains content that is similar to: https://github.com/IBM/CodeEngine/blob/main/hello/build
This file will make sure that automation picks up this sample and builds and pushes an image to icr.io/codeengine/<whatever-name-you-choose-in-the-build-file>
. This way we can easily link to this image in our docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also use a README to explain the intention
38084bd
to
4e965d3
Compare
3115663
to
e22e737
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Good job
My review was focussed on the overall integration into the samples repo, not so much on the source code.
Once @stevenwhitehead approves, this PR is good to go :)
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Enrico Regge <36001299+reggeenr@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Enrico Regge <36001299+reggeenr@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
91578ad
to
dbc83ed
Compare
…cated method Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
No description provided.