Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App to test network connectivity to CE services #133

Merged
merged 17 commits into from
Sep 23, 2024

Conversation

Nasir-Pauldon-Collins
Copy link
Contributor

No description provided.

@Nasir-Pauldon-Collins Nasir-Pauldon-Collins force-pushed the test-network-app branch 2 times, most recently from 128af89 to 79e5720 Compare September 18, 2024 19:59
@Nasir-Pauldon-Collins Nasir-Pauldon-Collins marked this pull request as ready for review September 18, 2024 19:59
Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nasir-Pauldon-Collins ,

thanks for working on this app, which will surely help clients and us to identify connectivity issues. I am looking forward to get this in.

Besides the two comments that I made, I suggest to also add a README which briefly describes what this sample is about and how it can be used (e.g. how should PG creds be configured)

Furthermore, I suggest to add a file called build, which contains content that is similar to: https://github.com/IBM/CodeEngine/blob/main/hello/build

This file will make sure that automation picks up this sample and builds and pushes an image to icr.io/codeengine/<whatever-name-you-choose-in-the-build-file>. This way we can easily link to this image in our docs.

network-test-app/app.js Outdated Show resolved Hide resolved
network-test-app/Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@stevenwhitehead stevenwhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also use a README to explain the intention

network-test-app/app.js Outdated Show resolved Hide resolved
network-test-app/app.js Show resolved Hide resolved
network-test-app/app.js Outdated Show resolved Hide resolved
network-test-app/app.js Show resolved Hide resolved
network-test-app/app.js Outdated Show resolved Hide resolved
network-test-app/README.md Outdated Show resolved Hide resolved
network-test-app/README.md Outdated Show resolved Hide resolved
network-test-app/README.md Outdated Show resolved Hide resolved
network-test-app/README.md Outdated Show resolved Hide resolved
reggeenr
reggeenr previously approved these changes Sep 20, 2024
Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Good job

My review was focussed on the overall integration into the samples repo, not so much on the source code.

Once @stevenwhitehead approves, this PR is good to go :)

network-test-app/app.js Outdated Show resolved Hide resolved
network-test-app/app.js Outdated Show resolved Hide resolved
Nasir-Pauldon-Collins and others added 15 commits September 20, 2024 14:55
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Enrico Regge <36001299+reggeenr@users.noreply.github.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Enrico Regge <36001299+reggeenr@users.noreply.github.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
…cated method

Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
@stevenwhitehead stevenwhitehead merged commit 83d43ad into IBM:main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants