App to test network connectivity to CE services#133
Merged
stevenwhitehead merged 17 commits intoIBM:mainfrom Sep 23, 2024
Merged
App to test network connectivity to CE services#133stevenwhitehead merged 17 commits intoIBM:mainfrom
stevenwhitehead merged 17 commits intoIBM:mainfrom
Conversation
Nasir-Pauldon-Collins
force-pushed
the
test-network-app
branch
2 times, most recently
from
128af89 to
79e5720
Compare
reggeenr
requested changes
Sep 18, 2024
Collaborator
reggeenr
left a comment
reggeenr
left a comment
There was a problem hiding this comment.
thanks for working on this app, which will surely help clients and us to identify connectivity issues. I am looking forward to get this in.
Besides the two comments that I made, I suggest to also add a README which briefly describes what this sample is about and how it can be used (e.g. how should PG creds be configured)
Furthermore, I suggest to add a file called build, which contains content that is similar to: https://github.com/IBM/CodeEngine/blob/main/hello/build
This file will make sure that automation picks up this sample and builds and pushes an image to icr.io/codeengine/<whatever-name-you-choose-in-the-build-file>. This way we can easily link to this image in our docs.
stevenwhitehead
requested changes
Sep 18, 2024
Member
stevenwhitehead
left a comment
stevenwhitehead
left a comment
There was a problem hiding this comment.
Could also use a README to explain the intention
Nasir-Pauldon-Collins
force-pushed
the
test-network-app
branch
from
38084bd to
4e965d3
Compare
stevenwhitehead
requested changes
Sep 20, 2024
Nasir-Pauldon-Collins
force-pushed
the
test-network-app
branch
from
3115663 to
e22e737
Compare
reggeenr
previously approved these changes
Sep 20, 2024
Collaborator
reggeenr
left a comment
reggeenr
left a comment
There was a problem hiding this comment.
LGTM - Good job
My review was focussed on the overall integration into the samples repo, not so much on the source code.
Once @stevenwhitehead approves, this PR is good to go :)
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Enrico Regge <36001299+reggeenr@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Enrico Regge <36001299+reggeenr@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Co-authored-by: Steven Whitehead <30630257+stevenwhitehead@users.noreply.github.com> Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
Nasir-Pauldon-Collins
force-pushed
the
test-network-app
branch
from
91578ad to
dbc83ed
Compare
…cated method Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
stevenwhitehead
previously approved these changes
Sep 20, 2024
Signed-off-by: Nasir Pauldon-Collins <nasir.pauldon-collins@ibm.com>
stevenwhitehead
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.