Refactor ECPrivateKey and allow getting public key #834
+363
−458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostasTsiounis
force-pushed
the
pkcs8_pubkey
branch
from
aa94062 to
3d9d4a7
Compare
KostasTsiounis
requested review from
JinhangZhang,
jasonkatonica,
johnpeck-us-ibm and
taoliult
johnpeck-us-ibm
requested changes
Oct 9, 2025
We are already importing Sun and BC keys in the |
The ECPrivateKey class is refactored to consolidate a single point of performing encoding operations. Functionality is added to allow saving the public key if provided with the private key encoding. Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
KostasTsiounis
force-pushed
the
pkcs8_pubkey
branch
from
f8ae985 to
3fd000c
Compare
jasonkatonica
approved these changes
Oct 16, 2025
taoliult
approved these changes
Oct 23, 2025
| */ | ||
| private byte[] createEncodedPrivateKeyWithParams() throws IOException { | ||
| DerInputStream privKeyBytesEncodedStream = new DerInputStream(this.privKeyMaterial); | ||
| DerValue[] inputDerValue = privKeyBytesEncodedStream.getSequence(4); |
There was a problem hiding this comment.
we have one additional value from the encoded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ECPrivateKeyclass is refactored to consolidate a single point of performing encoding operations.Functionality is added to allow saving the public key if provided with the private key encoding.
Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com