Feature/incremental sql pseudo #332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 28, 2024 14:39
Signed-off-by: Irfan Sharif <IrfanSharif@ibm.com>
Signed-off-by: Irfan Sharif <IrfanSharif@ibm.com>
Signed-off-by: Irfan Sharif <IrfanSharif@ibm.com>
edmundreinhardt
requested changes
Jul 9, 2024
Member
edmundreinhardt
left a comment
edmundreinhardt
left a comment
There was a problem hiding this comment.
Great work Irfan
- In the pull request provide an example of the new syntax within the Pseudo Source.
- Update the documentation to explain how to use this feature
- Update bob-recursive-example with an example of this and reference that in this pull request. Only merge the change in bob-recursive-example once a new release of bob has gone out.
Signed-off-by: Irfan Sharif <IrfanSharif@ibm.com>
Contributor
Author
|
Example of this feature https://github.com/IBM/bob-recursive-example |
added 2 commits
September 16, 2024 18:24
Signed-off-by: Irfan Sharif <IrfanSharif@ibm.com>
Collaborator
|
@edmundreinhardt The changes Irfan made after you comment look good. Anything else needed here or can we merge this as well? @irfanshar Great enhacement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.